git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] make remove-dashes: apply to scripts and programs as well, not just to builtins

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Jul 11, 2008, 00:12 UTC
Message-ID
<581f7ee17a4fb122f4df258d9cc0631b763fe9e1.1215734605.git.vmiklos@frugalware.org>
In-Reply-To
<eb505d0d8f7d2bf50073414baa799a80a9df7453.1215734605.git.vmiklos@frugalware.org>

All programs and scripts are now moved outside PATH, so it's a good idea not to use the dashed forms for them, either.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 Makefile       |    2 +-
 fixup-builtins |   18 +++++++++---------
 2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/Makefile b/Makefile
index 4796565..2b54d92 100644
--- a/Makefile
+++ b/Makefile
@@ -1296,7 +1296,7 @@ check: common-cmds.h
 	for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done
 
 remove-dashes:
-	./fixup-builtins $(BUILT_INS)
+	./fixup-builtins $(BUILT_INS) $(PROGRAMS) $(SCRIPTS)
 
 ### Installation rules
 
diff --git a/fixup-builtins b/fixup-builtins
index 49e861d..63dfa4c 100755
--- a/fixup-builtins
+++ b/fixup-builtins
@@ -1,16 +1,16 @@
 #!/bin/sh
 while [ "$1" ]
 do
-	old="$1"
-	new=$(echo "$1" | sed 's/git-/git /')
-	echo "Converting '$old' to '$new'"
-	git ls-files '*.sh' | while read file
-	do
-		sed "s/\\<$old\\>/$new/g" < $file > $file.new
-		chmod --reference=$file $file.new
-		mv $file.new $file
-	done
+	if [ "$1" != "git-sh-setup" -a "$1" != "git-parse-remote" -a "$1" != "git-svn" ]; then
+		old="$1"
+		new=$(echo "$1" | sed 's/git-/git /')
+		echo "Converting '$old' to '$new'"
+		sed -i "s/\\<$old\\>/$new/g" $(git ls-files '*.sh')
+	fi
 	shift
 done
+
+sed -i 's/git merge-one-file/git-merge-one-file/g
+s/git rebase-todo/git-rebase-todo/g' $(git ls-files '*.sh')
 git update-index --refresh >& /dev/null
 exit 0
-- 
1.5.6.2.450.g8d367.dirty
Previous: Miklos VajnaNext: Christian Couder
Message 5 of 9 in “Extend make remove-dashes”
  1. 0/5 Extend make remove-dashesMiklos Vajna, Jul 11, 2008
  2. 1/5 t0001-init.sh: change confusing directory nameMiklos Vajna, Jul 11, 2008
  3. 2/5 t1007-hash-object.sh: use quotes for the test descriptionMiklos Vajna, Jul 11, 2008
  4. 3/5 git-bisect: use dash-less form on git bisect logMiklos Vajna, Jul 11, 2008
  5. 4/5 make remove-dashes: apply to scripts and programs as well, not just to builtinsMiklos Vajna, Jul 11, 2008
  6. Christian CouderJul 11, 2008
  7. git-bisect: use dash-less form on git bisect logMiklos Vajna, Jul 11, 2008
  8. Christian CouderJul 13, 2008
  9. Junio C HamanoJul 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.