Re: [PATCH] git-bisect: use dash-less form on git bisect log

From: Christian Couder <chriscool@tuxfamily.org>
Date: Jul 13, 2008, 06:19 UTC
Message-ID: <200807130819.24206.chriscool@tuxfamily.org>
In-Reply-To: <1215792089-27201-1-git-send-email-vmiklos@frugalware.org>

Le vendredi 11 juillet 2008, Miklos Vajna a écrit :

Show 7 quoted lines

> Given that users are supposed to type 'git bisect' now, make the output
> of 'git bisect log' consistent with this.
>
> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
>
> On Fri, Jul 11, 2008 at 08:39:14AM +0200, Christian Couder

<chriscool@tuxfamily.org> wrote:

Show 15 quoted lines

> > Wouldn't it be better if bisect_replay could read old logs?
> >
> > Maybe with something like:
> >
> > +     while read git bisect command rev
> >       do
> > -             test "$bisect" = "git-bisect" || continue
> > +             test "$git $bisect" = "git bisect" -o "$git" =
> > "git-bisect" || continue
> > +             if test "$git" = "git-bisect"; then
> > +                     rev="$command"
> > +                     command="$bisect"
> > +             fi
>
> You are right, here is an updated patch.

Your patch looks good. But there is also the problem that new bisect logs will not be understood by old git. So I wonder if a patch to only read the new log should be first commited to the "maint" branch.

And sorry but I will be on vacation without Internet access for one week starting really soon now, so I will not be able to do anything soon, nor answer to any mails.

Thanks, Christian.