Re: [PATCH 05/38] refs: create a base class "ref_store" for files_ref_store

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Jun 10, 2016, 06:18 UTC
Message-ID: <575A5BCF.20409@alum.mit.edu>
In-Reply-To: <xmqq60tijq4g.fsf@gitster.mtv.corp.google.com>

On 06/09/2016 06:14 PM, Junio C Hamano wrote:

Show 11 quoted lines

> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>>>> +static struct ref_store *main_ref_store = NULL;
>>>> +
>>>> +static struct ref_store *submodule_ref_stores = NULL;
>>>
>>> Let's let BSS take care of these initialization.
> [...]
> Lack of "= ..." is a clear-enough clue that the code wants these
> pointers initialized to NULL.
> [...]

OK. While I'm at it I'll add docstrings for these variables.

Michael

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.