From: Michael Haggerty Date: Fri, 10 Jun 2016 06:18:55 GMT Subject: Re: [PATCH 05/38] refs: create a base class "ref_store" for files_ref_store Message-ID: <575A5BCF.20409@alum.mit.edu> In-Reply-To: On 06/09/2016 06:14 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >>>> +static struct ref_store *main_ref_store = NULL; >>>> + >>>> +static struct ref_store *submodule_ref_stores = NULL; >>> >>> Let's let BSS take care of these initialization. > [...] > Lack of "= ..." is a clear-enough clue that the code wants these > pointers initialized to NULL. > [...] OK. While I'm at it I'll add docstrings for these variables. Michael