Re: [PATCH] git-submodule should obey --quiet for subcommands

From: Jonathan del Strother <maillist@steelskies.com>
Date: Sep 24, 2009, 07:34 UTC
Message-ID: <57518fd10909240034p668f858bh17fc20715b4838c3@mail.gmail.com>
In-Reply-To: <20090924143130.6117@nanako3.lavabit.com>

On Thu, Sep 24, 2009 at 6:31 AM, Nanako Shiraishi <nanako3@lavabit.com> wrote:

Show 15 quoted lines

> Quoting Jonathan del Strother <maillist@steelskies.com>
>
>> No takers?  Perhaps I should explain my interest in this patch : we
>> use Capistrano to deploy our Rails app which contains a bunch of
>> submodules.  It's done over ssh, so the 'git submodule update' step
>> during deployment spews something along the lines of :
>>
>> Receiving objects: 0% (0/401), 1.55 MiB | 424 KiB/s
>> Receiving objects: 1% (4/401), 2.15 MiB | 612 KiB/s
>> Receiving objects: 2% (8/401), 2.90 MiB | 510 KiB/s
>> ....
>> ..
>
> Does 'git clone' itself do that to you, too, or do you see these output on separate lines only when running 'git submodule clone'? I never used 'git submodule clone' but with 'git clone' these lines seem to overwrite one after another and they never bothered me. Could your terminal emulator be broken?
>

No, git clone has the same problem when run under Capistrano, but it obeys --quiet.

That said, I always assumed that, say, 'ssh -t myhost git clone foo' would have the same problem (ie printing each progress update on a new line), but I see it works correctly. Looks like Capistrano is eating the \r somewhere. I still think my patch is valid, but I'll investigate into Capistrano some more & see if I can fix it there.

Jonathan