Re: [PATCH] git-submodule should obey --quiet for subcommands
- From
Jonathan del Strother <maillist@steelskies.com>
- Date
- Sep 23, 2009, 21:33 UTC
- Message-ID
- <57518fd10909231433i773aff78kae6b763d0a533279@mail.gmail.com>
- In-Reply-To
- <57518fd10909210946p425d275fy76362a4b2ccc0e05@mail.gmail.com>
On Mon, Sep 21, 2009 at 5:46 PM, Jonathan del Strother <maillist@steelskies.com> wrote:
Show 37 quoted lines
> Make sure that --quiet is passed through to git-clone & git-fetch.
>
> Signed-off-by: Jonathan del Strother <jon.delStrother@bestbefore.tv>
> ---
> clone & fetch are extremely noisy - perhaps something like the following?
>
> git-submodule.sh | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index bfbd36b..1e1066e 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -106,9 +106,9 @@ module_clone()
>
> if test -n "$reference"
> then
> - git-clone "$reference" -n "$url" "$path"
> + git-clone ${GIT_QUIET:+-q} "$reference" -n "$url" "$path"
> else
> - git-clone -n "$url" "$path"
> + git-clone ${GIT_QUIET:+-q} -n "$url" "$path"
> fi ||
> die "Clone of '$url' into submodule path '$path' failed"
> }
> @@ -450,7 +450,7 @@ cmd_update()
> if test -z "$nofetch"
> then
> (unset GIT_DIR; cd "$path" &&
> - git-fetch) ||
> + git-fetch ${GIT_QUIET:+-q}) ||
> die "Unable to fetch in submodule path '$path'"
> fi
>
> --
> 1.6.5.rc1.44.ga1675.dirty
>No takers? Perhaps I should explain my interest in this patch : we use Capistrano to deploy our Rails app which contains a bunch of submodules. It's done over ssh, so the 'git submodule update' step during deployment spews something along the lines of :
Receiving objects: 0% (0/401), 1.55 MiB | 424 KiB/s Receiving objects: 1% (4/401), 2.15 MiB | 612 KiB/s Receiving objects: 2% (8/401), 2.90 MiB | 510 KiB/s .... .. .
all the way up to 100% to the console. Currently we're just directing stdout to /dev/null, since --quiet failed to accomplish much, but it seems like something along the lines of this patch would be useful.
Unless someone has a better implementation...?