Re: [PATCH v3 0/8] Maintenance II: prefetch, loose-objects, incremental-repack tasks

From: Son Luong Ngoc <sluongng@gmail.com>
Date: Aug 26, 2020, 15:15 UTC
Message-ID: <56C4015E-B431-4B16-8E05-5919BFA71E80@gmail.com>
In-Reply-To: <pull.696.v3.git.1598380599.gitgitgadget@gmail.com>

Hi Derrick,

> On Aug 25, 2020, at 20:36, Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
>

...

Show 14 quoted lines

> 
> Updates since v2
> ================
> 
> * Dropped "fetch: optionally allow disabling FETCH_HEAD update"
> 
> 
> * A lot of fallout from the change in the option parsing in v3 of
>   Maintenance II.
> 
> 
> * Dropped the "verify, and delete and rewrite on failure" logic from the
>   incremental-repack task. This might be added again later after it can be
>   tested more thoroughly.

Perhaps I missed some conversations related to this change but why was this verify-rewrite strategy dropped?

Was the problem such strategy were created to solve is now no longer a concern?

I feel like it would be much better to add it in and then remove it using a separated commit? That way we can follow the reasoning behind these decisions via commit message.

...

> 
> -- 
> gitgitgadget

Thanks, Son Luong.