Re: [PATCH v4 08/21] refs: add methods to init refs db
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Feb 11, 2016, 08:54 UTC
- Message-ID
- <56BC4C3D.8040505@alum.mit.edu>
- In-Reply-To
- <1454701462-3817-9-git-send-email-dturner@twopensource.com>
On 02/05/2016 08:44 PM, David Turner wrote:
Show 22 quoted lines
> Alternate refs backends might not need the refs/heads directory and so > on, so we make ref db initialization part of the backend. > > Signed-off-by: David Turner <dturner@twopensource.com> > --- > builtin/init-db.c | 20 ++++++++++---------- > refs.c | 5 +++++ > refs.h | 2 ++ > refs/files-backend.c | 16 ++++++++++++++++ > refs/refs-internal.h | 2 ++ > 5 files changed, 35 insertions(+), 10 deletions(-) > > [...] > diff --git a/refs.h b/refs.h > index 5bc3fbc..c5ecc52 100644 > --- a/refs.h > +++ b/refs.h > @@ -66,6 +66,8 @@ extern int ref_exists(const char *refname); > > extern int is_branch(const char *refname); > > +extern int refs_init_db(struct strbuf *err, int shared);
The convention elsewhere is for "struct strbuf *err" to be the *last* parameter.
> [...]
Michael
-- Michael Haggerty mhagger@alum.mit.edu