Re: [PATCH v4 12/21] refs: allow log-only updates

From: David Turner <dturner@twopensource.com>
Date: Feb 11, 2016, 21:23 UTC
Message-ID: <1455225803.29013.13.camel@twopensource.com>
In-Reply-To: <56BC5C8C.8060201@alum.mit.edu>

On Thu, 2016-02-11 at 11:03 +0100, Michael Haggerty wrote:

Show 8 quoted lines

> On 02/05/2016 08:44 PM, David Turner wrote:
> > The refs infrastructure learns about log-only ref updates, which
> > only
> > update the reflog.  Later, we will use this to separate symbolic
> > reference resolution from ref updating.
> 
> This looks good. I assume it will get some testing later in the
> series.

The existing tests cover this pretty well, I think. It's not intended to have user-visible results, so it's hard to specifically test.

Show 13 quoted lines

> > [...]
> > diff --git a/refs/refs-internal.h b/refs/refs-internal.h
> > index fc5d1db..b5d0ab8 100644
> > --- a/refs/refs-internal.h
> > +++ b/refs/refs-internal.h
> > @@ -42,6 +42,8 @@
> >   * value to ref_update::flags
> >   */
> >  
> > +#define REF_LOG_ONLY 0x80
> > +
> 
> Please add a comment explaining the meaning/purpose of this flag.

Commented, thanks.