[PATCH 1/2] git-svn: enable "svn.pathnameencoding" on dcommit
- From
Kazutoshi Satoda <k_satoda@f2.dion.ne.jp>
- Date
- Feb 8, 2016, 15:20 UTC
- Message-ID
- <56B8B23F.2020901@f2.dion.ne.jp>
- In-Reply-To
- <56B8B1EA.5020901@f2.dion.ne.jp>
Without the initialization of $self->{pathnameencoding}, conversion in repo_path() is always skipped as $self->{pathnameencoding} is undefined even if "svn.pathnameencoding" is configured.
The lack of conversion results in mysterious failure of dcommit (e.g. "Malformed XML") which happen only when a commit involves a change on non-ASCII path.
Signed-off-by: Kazutoshi SATODA <k_satoda@f2.dion.ne.jp> --- perl/Git/SVN/Editor.pm | 1 + 1 file changed, 1 insertion(+)
diff --git a/perl/Git/SVN/Editor.pm b/perl/Git/SVN/Editor.pm index c50176e..d9d9bdf 100644 --- a/perl/Git/SVN/Editor.pm +++ b/perl/Git/SVN/Editor.pm @@ -41,6 +41,7 @@ sub new { "$self->{svn_path}/" : ''; $self->{config} = $opts->{config}; $self->{mergeinfo} = $opts->{mergeinfo}; + $self->{pathnameencoding} = Git::config('svn.pathnameencoding'); return $self; }
-- 2.7.0