[PATCH 0/2] enable "svn.pathnameencoding" on dcommit
- From
Kazutoshi Satoda <k_satoda@f2.dion.ne.jp>
- Date
- Feb 8, 2016, 15:19 UTC
- Message-ID
- <56B8B1EA.5020901@f2.dion.ne.jp>
These are small fixes to problems I encountered using git-svn with svn.pathnameencoding configuration (cp932 in my case). The problems happen only when sending changes on non-ASCII paths.
I'm sorry not coming with test scripts, but I couldn't figure out how to write tests to reproduce problems happen only with non-UTF-8 paths while the tests seems to be run on UTF-8 locale.
I just ran existing tests with these fixes and there was no breakage (with UTF-8 locale).
I think sending these fixes as-is is better than not sending because of my lack of ability to write such tests. I also expect that these fixes can be applied as-is because there were some small fixes without tests in the history of file perl/Git/SVN/Editor.pm.
The first one is an updated fix of an very old but not applied patch. http://comments.gmane.org/gmane.comp.version-control.git/164166#o2
The second one can be seen as a separate fix, but it takes effect only after the first one.
Kazutoshi SATODA (2): git-svn: enable "svn.pathnameencoding" on dcommit git-svn: apply "svn.pathnameencoding" before URL encoding
perl/Git/SVN/Editor.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
-- 2.7.0