git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] remote: read $GIT_DIR/branches/* with strbuf_getline()

From
MNMoritz Neeb <lists@moritzneeb.de>
Date
Jan 30, 2016, 18:05 UTC
Message-ID
<56ACFB6D.4040804@moritzneeb.de>
In-Reply-To
<56ACF82B.2030005@moritzneeb.de>
    The line read from the branch file is directly trimmed after
    reading with strbuf_trim(). There is thus no logic expecting CR,
    so strbuf_getline_lf() can be replaced by its CRLF counterpart.
Signed-off-by: Moritz Neeb <lists@moritzneeb.de>
---
 remote.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/remote.c b/remote.c
index 7d61dab..78f97f0 100644
--- a/remote.c
+++ b/remote.c
@@ -281,7 +281,7 @@ static void read_branches_file(struct remote *remote)
 	if (!f)
 		return;
 -	strbuf_getline_lf(&buf, f);
+	strbuf_getline(&buf, f);
 	fclose(f);
 	strbuf_trim(&buf);
 	if (!buf.len) {
-- 
2.4.3
Previous: Junio C HamanoNext: Moritz Neeb
Message 12 of 14 in “Replacing strbuf_getline_lf() by strbuf_getline() on trimmed input”
  1. 0/5 Replacing strbuf_getline_lf() by strbuf_getline() on trimmed inputMoritz Neeb, Jan 30, 2016
  2. 1/5 bisect: read bisect paths with strbuf_getline()Moritz Neeb, Jan 30, 2016
  3. Junio C HamanoFeb 1, 2016
  4. Moritz NeebFeb 14, 2016
  5. Junio C HamanoFeb 15, 2016
  6. Moritz NeebFeb 21, 2016
  7. Moritz NeebFeb 22, 2016
  8. 2/5 clean: read user input with strbuf_getline()Moritz Neeb, Jan 30, 2016
  9. Junio C HamanoFeb 1, 2016
  10. 3/5 notes: read copied notes with strbuf_getline()Moritz Neeb, Jan 30, 2016
  11. Junio C HamanoFeb 1, 2016
  12. 4/5 remote: read $GIT_DIR/branches/* with strbuf_getline()Moritz Neeb, Jan 30, 2016
  13. 5/5 wt-status: read rebase todolist with strbuf_getline()Moritz Neeb, Jan 30, 2016
  14. Junio C HamanoFeb 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.