git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] clean: read user input with strbuf_getline()

From
MNMoritz Neeb <lists@moritzneeb.de>
Date
Jan 30, 2016, 18:04 UTC
Message-ID
<56ACFB3D.6010309@moritzneeb.de>
In-Reply-To
<56ACF82B.2030005@moritzneeb.de>
    The input that is read is trimmed with strbuf_trim() immediately.
    There is thus no logic expecting CR, so strbuf_getline_lf() can be
    replaced by its CRLF counterpart.
Signed-off-by: Moritz Neeb <lists@moritzneeb.de>
---
 builtin/clean.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/clean.c b/builtin/clean.c
index 7b08237..956283d 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -570,7 +570,7 @@ static int *list_and_choose(struct menu_opts *opts, struct menu_stuff *stuff)
 			       clean_get_color(CLEAN_COLOR_RESET));
 		}
 -		if (strbuf_getline_lf(&choice, stdin) != EOF) {
+		if (strbuf_getline(&choice, stdin) != EOF) {
 			strbuf_trim(&choice);
 		} else {
 			eof = 1;
@@ -652,7 +652,7 @@ static int filter_by_patterns_cmd(void)
 		clean_print_color(CLEAN_COLOR_PROMPT);
 		printf(_("Input ignore patterns>> "));
 		clean_print_color(CLEAN_COLOR_RESET);
-		if (strbuf_getline_lf(&confirm, stdin) != EOF)
+		if (strbuf_getline(&confirm, stdin) != EOF)
 			strbuf_trim(&confirm);
 		else
 			putchar('\n');
@@ -750,7 +750,7 @@ static int ask_each_cmd(void)
 			qname = quote_path_relative(item->string, NULL, &buf);
 			/* TRANSLATORS: Make sure to keep [y/N] as is */
 			printf(_("Remove %s [y/N]? "), qname);
-			if (strbuf_getline_lf(&confirm, stdin) != EOF) {
+			if (strbuf_getline(&confirm, stdin) != EOF) {
 				strbuf_trim(&confirm);
 			} else {
 				putchar('\n');
-- 
2.4.3
Previous: Moritz NeebNext: Junio C Hamano
Message 8 of 14 in “Replacing strbuf_getline_lf() by strbuf_getline() on trimmed input”
  1. 0/5 Replacing strbuf_getline_lf() by strbuf_getline() on trimmed inputMoritz Neeb, Jan 30, 2016
  2. 1/5 bisect: read bisect paths with strbuf_getline()Moritz Neeb, Jan 30, 2016
  3. Junio C HamanoFeb 1, 2016
  4. Moritz NeebFeb 14, 2016
  5. Junio C HamanoFeb 15, 2016
  6. Moritz NeebFeb 21, 2016
  7. Moritz NeebFeb 22, 2016
  8. 2/5 clean: read user input with strbuf_getline()Moritz Neeb, Jan 30, 2016
  9. Junio C HamanoFeb 1, 2016
  10. 3/5 notes: read copied notes with strbuf_getline()Moritz Neeb, Jan 30, 2016
  11. Junio C HamanoFeb 1, 2016
  12. 4/5 remote: read $GIT_DIR/branches/* with strbuf_getline()Moritz Neeb, Jan 30, 2016
  13. 5/5 wt-status: read rebase todolist with strbuf_getline()Moritz Neeb, Jan 30, 2016
  14. Junio C HamanoFeb 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.