Re: [PATCH v7 1/2] config.mak.uname: Darwin: define NO_GETTEXT for OS X 10.9 and later

From: Torsten Bögershausen <tboegi@web.de>
Date: Nov 23, 2015, 11:57 UTC
Message-ID: <5652FF18.20602@web.de>
In-Reply-To: <1448267108-55652-2-git-send-email-larsxschneider@gmail.com>

On 11/23/2015 09:25 AM, larsxschneider@gmail.com wrote:

Show 29 quoted lines

> From: Lars Schneider <larsxschneider@gmail.com>
>
> At least since OS X 10.9 Mavericks "libintl.h" is not available on OS X
> anymore. Disable the support with the NO_GETTEXT flag.
>
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
>   config.mak.uname | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index f34dcaa..f3d98bb 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -102,9 +102,14 @@ ifeq ($(uname_S),Darwin)
>   	ifeq ($(shell expr "$(uname_R)" : '[15]\.'),2)
>   		NO_STRLCPY = YesPlease
>   	endif
> +	# MacOS 10.7 Lion and higher
>   	ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 11 && echo 1),1)
>   		HAVE_GETDELIM = YesPlease
>   	endif
> +	# MacOS 10.9 Mavericks and higher
> +	ifeq ($(shell test "`expr "$(uname_R)" : '\([0-9][0-9]*\)\.'`" -ge 13 && echo 1),1)
> +		NO_GETTEXT = YesPlease
> +	endif
>   	NO_MEMMEM = YesPlease
>   	USE_ST_TIMESPEC = YesPlease
>   	HAVE_DEV_TTY = YesPlease

Unless I'm wrong, no Mac OS X had libintl.h, and the "unwritten agreement (?)" was that either a) libintl ist installed in some way (fink, mac ports, brew, other ways) or b) people use NO_GETTEXT=yes make

Doesn't this patch close the door for b), making it impossible to build Git against libintl ? A better test may if libintl is installed may help, or better documentation.