Re: [PATCH v7 2/2] Add Travis CI support
- From
Jeff King <peff@peff.net>
- Date
- Nov 24, 2015, 20:40 UTC
- Message-ID
- <20151124204004.GC7174@sigill.intra.peff.net>
- In-Reply-To
- <1448267108-55652-3-git-send-email-larsxschneider@gmail.com>
On Mon, Nov 23, 2015 at 09:25:08AM +0100, larsxschneider@gmail.com wrote:
Show 7 quoted lines
> From: Lars Schneider <larsxschneider@gmail.com> > > The tests are currently executed on "Ubuntu 12.04 LTS Server Edition > 64 bit" and on "OS X Mavericks" using gcc and clang. > > Perforce and Git-LFS are installed and therefore available for the > respective tests.
Thanks, I find this one a little easier to digest.
I'm iffy on the NO_GETTEXT change from patch 1. I had hoped we could just build out of the box everywhere, but I think the "do we have libintl" decision is a hard one. Most people _do_ have it and want it, but it sounds like the Travis environment does not. So maybe it is a place where it is worth doing the tweak inside travis.yml and leaving the stock build alone.
-Peff