git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit

From
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date
Jun 1, 2015, 17:45 UTC
Message-ID
<563732680.250935.1433180720935.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To
<xmqqvbf7757q.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
> Is this sufficient?
> If you are going to do something in 2/2 that relies on the format of
> this line being correct (as opposed to "noop" or "#" that can have
> any garbage on the remainder of the line), wouldn't you want to at
> least check $sha1 is sensible?

That's also something that I was wondering, I wrote about it in the 0/2 part of this patch, I wanted some opinion about it. If there is no opposition on the subject, I will have it ready for the v3 of the patch.

Quote of that part of the 0/2 for more clarity: Galan Rémi <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:

> For the 'drop' command, maybe instead of just doing the same thing as
> noop, checking if the SHA-1 that supposedly follow does exist could be
> a good idea.
Previous: Matthieu MoyNext: Matthieu Moy
Message 5 of 12 in “rebase -i : drop command and removed commits”
  1. 0/2 rebase -i : drop command and removed commitsGalan Rémi, Jun 1, 2015
  2. 1/2 git-rebase -i: add command "drop" to remove a commitGalan Rémi, Jun 1, 2015
  3. Junio C HamanoJun 1, 2015
  4. Matthieu MoyJun 1, 2015
  5. Remi Galan AlfonsoJun 1, 2015
  6. Matthieu MoyJun 1, 2015
  7. Remi Galan AlfonsoJun 2, 2015
  8. Matthieu MoyJun 2, 2015
  9. Junio C HamanoJun 2, 2015
  10. Remi Galan AlfonsoJun 3, 2015
  11. Junio C HamanoJun 3, 2015
  12. 2/2 git rebase -i: warn about removed commitsGalan Rémi, Jun 1, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.