From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Mon, 01 Jun 2015 17:45:20 GMT
Subject: Re: [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit
Message-ID: <563732680.250935.1433180720935.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <xmqqvbf7757q.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:
> Is this sufficient?

> If you are going to do something in 2/2 that relies on the format of
> this line being correct (as opposed to "noop" or "#" that can have
> any garbage on the remainder of the line), wouldn't you want to at
> least check $sha1 is sensible?

That's also something that I was wondering, I wrote about it in the
0/2 part of this patch, I wanted some opinion about it.
If there is no opposition on the subject, I will have it ready for
the v3 of the patch.

Quote of that part of the 0/2 for more clarity:
Galan Rémi <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
> For the 'drop' command, maybe instead of just doing the same thing as
> noop, checking if the SHA-1 that supposedly follow does exist could be
> a good idea.