git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 01/13] refs: convert some internal functions to use object_id

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Oct 13, 2015, 11:43 UTC
Message-ID
<561CEE62.4030403@alum.mit.edu>
In-Reply-To
<1444355039-186351-2-git-send-email-sandals@crustytoothpaste.net>
On 10/09/2015 03:43 AM, brian m. carlson wrote:
Show 5 quoted lines
> Convert several internal functions in refs.c to use struct object_id,
> and use the GIT_SHA1_HEXSZ constants in parse_ref_line.
> 
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> [...]
I looked over this patch at the diff level and didn't find any problems.

This patch conflicts heavily with [1]. But I noticed that it is independent of the rest of your series. I don't know when either patch series will be ready, but see [2] for my take on the other one.

Assuming neither series is rejected, I think it would be much easier to redo this patch on top of the first part of [1] than vice versa, so that would be my suggestion. If it comes down to that, I am willing to help redo this patch if you like.

Michael

[1] http://thread.gmane.org/gmane.comp.version-control.git/279423 [2] http://article.gmane.org/gmane.comp.version-control.git/279496

-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: brian m. carlsonNext: brian m. carlson
Message 3 of 16 in “object_id part 2”
  1. 00/13 object_id part 2brian m. carlson, Oct 9, 2015
  2. 01/13 refs: convert some internal functions to use object_idbrian m. carlson, Oct 9, 2015
  3. Michael HaggertyOct 13, 2015
  4. brian m. carlsonOct 14, 2015
  5. 02/13 sha1_file: introduce has_object_file helper.brian m. carlson, Oct 9, 2015
  6. 03/13 Convert struct ref to use object_id.brian m. carlson, Oct 9, 2015
  7. 04/13 add_sought_entry_mem: convert to struct object_idbrian m. carlson, Oct 9, 2015
  8. 05/13 parse_fetch: convert to use struct object_idbrian m. carlson, Oct 9, 2015
  9. 06/13 get_remote_heads: convert to struct object_idbrian m. carlson, Oct 9, 2015
  10. 07/13 push_refs_with_export: convert to struct object_idbrian m. carlson, Oct 9, 2015
  11. 08/13 ref_newer: convert to use struct object_idbrian m. carlson, Oct 9, 2015
  12. 09/13 object: introduce get_object_hash macro.brian m. carlson, Oct 9, 2015
  13. 10/13 Add several uses of get_object_hash.brian m. carlson, Oct 9, 2015
  14. 11/13 Convert struct object to object_idbrian m. carlson, Oct 9, 2015
  15. 12/13 Remove get_object_hash.brian m. carlson, Oct 9, 2015
  16. 13/13 remote: convert functions to struct object_idbrian m. carlson, Oct 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.