git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 07/13] push_refs_with_export: convert to struct object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 9, 2015, 01:43 UTC
Message-ID
<1444355039-186351-8-git-send-email-sandals@crustytoothpaste.net>
In-Reply-To
<1444355039-186351-1-git-send-email-sandals@crustytoothpaste.net>
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 transport-helper.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 91cb0e72..0eb3cf01 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -878,13 +878,13 @@ static int push_refs_with_export(struct transport *transport,
 
 	for (ref = remote_refs; ref; ref = ref->next) {
 		char *private;
-		unsigned char sha1[20];
+		struct object_id oid;
 
 		private = apply_refspecs(data->refspecs, data->refspec_nr, ref->name);
-		if (private && !get_sha1(private, sha1)) {
+		if (private && !get_sha1(private, oid.hash)) {
 			strbuf_addf(&buf, "^%s", private);
 			string_list_append(&revlist_args, strbuf_detach(&buf, NULL));
-			hashcpy(ref->old_oid.hash, sha1);
+			oidcpy(&ref->old_oid, &oid);
 		}
 		free(private);
 
@@ -898,7 +898,7 @@ static int push_refs_with_export(struct transport *transport,
 					name = resolve_ref_unsafe(
 						 ref->peer_ref->name,
 						 RESOLVE_REF_READING,
-						 sha1, &flag);
+						 oid.hash, &flag);
 					if (!name || !(flag & REF_ISSYMREF))
 						name = ref->peer_ref->name;
 

-- 
2.6.1
Previous: brian m. carlsonNext: brian m. carlson
Message 10 of 16 in “object_id part 2”
  1. 00/13 object_id part 2brian m. carlson, Oct 9, 2015
  2. 01/13 refs: convert some internal functions to use object_idbrian m. carlson, Oct 9, 2015
  3. Michael HaggertyOct 13, 2015
  4. brian m. carlsonOct 14, 2015
  5. 02/13 sha1_file: introduce has_object_file helper.brian m. carlson, Oct 9, 2015
  6. 03/13 Convert struct ref to use object_id.brian m. carlson, Oct 9, 2015
  7. 04/13 add_sought_entry_mem: convert to struct object_idbrian m. carlson, Oct 9, 2015
  8. 05/13 parse_fetch: convert to use struct object_idbrian m. carlson, Oct 9, 2015
  9. 06/13 get_remote_heads: convert to struct object_idbrian m. carlson, Oct 9, 2015
  10. 07/13 push_refs_with_export: convert to struct object_idbrian m. carlson, Oct 9, 2015
  11. 08/13 ref_newer: convert to use struct object_idbrian m. carlson, Oct 9, 2015
  12. 09/13 object: introduce get_object_hash macro.brian m. carlson, Oct 9, 2015
  13. 10/13 Add several uses of get_object_hash.brian m. carlson, Oct 9, 2015
  14. 11/13 Convert struct object to object_idbrian m. carlson, Oct 9, 2015
  15. 12/13 Remove get_object_hash.brian m. carlson, Oct 9, 2015
  16. 13/13 remote: convert functions to struct object_idbrian m. carlson, Oct 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.