Re: [PATCH 1/1] git-gui: fix colored label backgrounds when using themed widgets

From: Stefan Haller <stefan@haller-berlin.de>
Date: Dec 8, 2020, 15:20 UTC
Message-ID: <55dfab3f-e031-615f-435a-aad78d0a0c73@haller-berlin.de>
In-Reply-To: <20201206130711.halhskksavsvojm2@yadavpratyush.com>

On 06.12.20 14:07, Pratyush Yadav wrote:

Show 19 quoted lines

> On 02/12/20 09:52AM, Stefan Haller wrote:
>> On 01.12.20 21:06, Pratyush Yadav wrote:
>>> Hi Stefan,
>>>
>>> Thanks for the patch.
>>>
>>> On 22/11/20 08:45PM, Stefan Haller wrote:
>>>> The aqua theme on Mac doesn't support changing the background color for labels
>>>> and frames [1]. Since the red, green, and yellow backgrounds of the labels for
>>>> unstaged and staged files and the diff pane are so important design elements of
>>>> git gui's main window, it's not acceptable for them to have grey backgrounds on
>>>> Mac.
>>>
>>> I unfortunately don't have access to a Mac machine to I can't test this 
>>> patch.
>>
>> I could send screenshots if that helps.
> 
> Yes, that would be helpful.

Here are some screenshots; with and without the patch, with and without ttk, and in light mode and dark mode.

   https://cp.sync.com/dl/1cf0e2cd0/dynix3qc-ev5q8crr-sp2kjxuy-h4pcwr68

-Stefan