git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] git-gui: fix colored label backgrounds when using themed widgets

From
Pratyush Yadav <me@yadavpratyush.com>
Date
Dec 17, 2020, 19:03 UTC
Message-ID
<20201217190317.pbsozw7kl5vxtwmi@yadavpratyush.com>
In-Reply-To
<20201122194537.41870-2-stefan@haller-berlin.de>
On 22/11/20 08:45PM, Stefan Haller wrote:
Show 17 quoted lines
> The aqua theme on Mac doesn't support changing the background color for labels
> and frames [1]. Since the red, green, and yellow backgrounds of the labels for
> unstaged and staged files and the diff pane are so important design elements of
> git gui's main window, it's not acceptable for them to have grey backgrounds on
> Mac.
> 
> To work around this, simply use non-themed widgets for all labels on Mac. This
> is not a big problem because labels don't look extremely different between the
> themed and non-themed versions. There are subtle differences, but they are not
> as bad as having the wrong background color.
> 
> [1] https://stackoverflow.com/a/6723911
> 
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
> ---
>  lib/themed.tcl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
Applied to git-gui/master. Thanks.
-- 
Regards,
Pratyush Yadav
Previous: Stefan Haller
Message 7 of 7 in “git-gui: fix colored label backgrounds on Mac”
  1. 0/1 git-gui: fix colored label backgrounds on MacStefan Haller, Nov 22, 2020
  2. 1/1 git-gui: fix colored label backgrounds when using themed widgetsStefan Haller, Nov 22, 2020
  3. Pratyush YadavDec 1, 2020
  4. Stefan HallerDec 2, 2020
  5. Pratyush YadavDec 6, 2020
  6. Stefan HallerDec 8, 2020
  7. Pratyush YadavDec 17, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.