git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] t1517: add missing LIBCURL prereq

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Sep 11, 2024, 10:30 UTC
Message-ID
<55d45be1d6775a630b9f61487b6b60efab9c7769.1726049108.git.martin.agren@gmail.com>
In-Reply-To
<cover.1726049108.git.martin.agren@gmail.com>

After building Git with NO_LIBCURL, there is no `git remote-http`, so it's not meaningful to test that it can run outside of a repository. Indeed, that test will fail. Add the LIBCURL prereq to it.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
 This is from b25ec8b8d5 (t1517: more coverage for commands that work
 without repository, 2024-05-31), which first appeared in 2.46.0.
 t/t1517-outside-repo.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh
index 990a036582..342defbb61 100755
--- a/t/t1517-outside-repo.sh
+++ b/t/t1517-outside-repo.sh
@@ -98,7 +98,7 @@ test_expect_success 'stripspace outside repository' '
 	nongit git stripspace -s </dev/null
 '
 
-test_expect_success 'remote-http outside repository' '
+test_expect_success LIBCURL 'remote-http outside repository' '
 	test_must_fail git remote-http 2>actual &&
 	test_grep "^error: remote-curl" actual &&
 	(
-- 
2.46.0.733.g1eb83ef1a1
Previous: Martin ÅgrenNext: Martin Ågren
Message 2 of 4 in “add missing LIBCURL prereq to a few tests”
  1. 0/2 add missing LIBCURL prereq to a few testsMartin Ågren, Sep 11, 2024
  2. 1/2 t1517: add missing LIBCURL prereqMartin Ågren, Sep 11, 2024
  3. 2/2 t0211: add missing LIBCURL prereqMartin Ågren, Sep 11, 2024
  4. Junio C HamanoSep 11, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.