git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] t0211: add missing LIBCURL prereq

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Sep 11, 2024, 10:31 UTC
Message-ID
<4f749b283be03e11af30e6ad14909c22834dc3e5.1726049108.git.martin.agren@gmail.com>
In-Reply-To
<cover.1726049108.git.martin.agren@gmail.com>

After building Git with NO_LIBCURL, we're lacking `git remote-http` and `git http-fetch`, so when we test that they trace as they should, we're bound to fail. Add the LIBCURL prereq to those tests.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
 This is from around 6111252cbf (trace2: emit 'def_param' set with
 'cmd_name' event, 2024-03-07), which first appeared in 2.45.0.
 t/t0211-trace2-perf.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh
index 070fe7a5da..dddc130560 100755
--- a/t/t0211-trace2-perf.sh
+++ b/t/t0211-trace2-perf.sh
@@ -337,7 +337,8 @@ test_expect_success 'expect def_params for query command' '
 # remote-curl.c rather than git.c.  Confirm that we get def_param
 # events from both layers.
 #
-test_expect_success 'expect def_params for remote-curl and _run_dashed_' '
+test_expect_success LIBCURL \
+		'expect def_params for remote-curl and _run_dashed_' '
 	test_when_finished "rm prop.perf actual" &&
 
 	test_config_global "trace2.configParams" "cfg.prop.*" &&
@@ -366,7 +367,8 @@ test_expect_success 'expect def_params for remote-curl and _run_dashed_' '
 # an executable built from http-fetch.c.  Confirm that we get
 # def_param events from both layers.
 #
-test_expect_success 'expect def_params for http-fetch and _run_dashed_' '
+test_expect_success LIBCURL \
+		'expect def_params for http-fetch and _run_dashed_' '
 	test_when_finished "rm prop.perf actual" &&
 
 	test_config_global "trace2.configParams" "cfg.prop.*" &&
-- 
2.46.0.733.g1eb83ef1a1
Previous: Martin ÅgrenNext: Junio C Hamano
Message 3 of 4 in “add missing LIBCURL prereq to a few tests”
  1. 0/2 add missing LIBCURL prereq to a few testsMartin Ågren, Sep 11, 2024
  2. 1/2 t1517: add missing LIBCURL prereqMartin Ågren, Sep 11, 2024
  3. 2/2 t0211: add missing LIBCURL prereqMartin Ågren, Sep 11, 2024
  4. Junio C HamanoSep 11, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.