Re: [PATCH] config.mak.uname: Cygwin: Use renames for creation

From: Mark Levedahl <mlevedahl@gmail.com>
Date: Aug 8, 2015, 20:47 UTC
Message-ID: <55C66AF2.3060706@gmail.com>
In-Reply-To: <1438979428-5888-1-git-send-email-adam@dinwoodie.org>

On 08/07/2015 04:30 PM, Adam Dinwoodie wrote:

Show 28 quoted lines

> When generating build options for Cygwin, enable
> OBJECT_CREATION_USES_RENAMES.  This is necessary to use Git on Windows
> shared directories, and is already enabled for the MinGW and plain
> Windows builds.
>
> This problem was reported on the Cygwin mailing list at
> https://cygwin.com/ml/cygwin/2015-08/msg00102.html (amongst others) and
> is being applied as a manual patch to the Cygwin builds until the patch
> is taken here.
>
> Reported-by: Peter Rosin <peda@lysator.liu.se>
> Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
> ---
>   config.mak.uname | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 943c439..be5cbec 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -187,6 +187,7 @@ ifeq ($(uname_O),Cygwin)
>   	X = .exe
>   	UNRELIABLE_FSTAT = UnfortunatelyYes
>   	SPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield
> +	OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
>   endif
>   ifeq ($(uname_S),FreeBSD)
>   	NEEDS_LIBICONV = YesPlease

I've been supporting use of git on cygwin since about 2008, this issue has never risen that I know. Whatever issue is being patched around here, if truly repeatable, should be handled by the cygwin dll as that code is focused on providing full linux compatibility. If git on linux does need this patch, git on cygwin should not, either. So, I vote against this.

Mark