git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 0/7] refs backend preamble

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jul 21, 2015, 20:20 UTC
Message-ID
<55AEA998.60501@alum.mit.edu>
In-Reply-To
<1437493504-3699-1-git-send-email-dturner@twopensource.com>
On 07/21/2015 08:44 AM, David Turner wrote:
Show 6 quoted lines
> This reroll addresses Michael Haggerty's comments:
> 
> - Error messages are now in the form error: reason
> - We no longer unnecessarily set errno in write_ref_to_lockfile
> - Corrected a spelling error in the new docs and another in the tests
> - Corrected some copypasta in a test.

Isn't it sobering that, every time one looks at source code, one finds things that could be improved? (Not just yours but all source code!) Happily it seems like the items are getting ever more trivial, and either with or without the last round of suggestions I think the code is correct and is a nice step forward.

Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Off topic: I wonder whether sooner or later we will need a
    git reflog remove <ref>

to delete an existing reference's reflog entirely without deleting the reference and without assuming a filesystem backend. (Note that this is different than `git reflog expire`, which leaves the empty reflog file around and thus doesn't undo a --create-reflog.) But perhaps there is no call for that operation. In a pinch a user could delete the reference and recreate it to get rid of its reflog.

Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: David TurnerNext: David Turner
Message 15 of 18 in “refs backend preamble”
  1. 0/7 refs backend preambleDavid Turner, Jul 21, 2015
  2. 1/7 refs.c: add err arguments to reflog functionsDavid Turner, Jul 21, 2015
  3. Michael HaggertyJul 21, 2015
  4. 2/7 refs: Break out check for reflog autocreationDavid Turner, Jul 21, 2015
  5. 3/7 refs: new public ref function: safe_create_reflogDavid Turner, Jul 21, 2015
  6. Michael HaggertyJul 21, 2015
  7. 4/7 git-reflog: add exists commandDavid Turner, Jul 21, 2015
  8. Michael HaggertyJul 21, 2015
  9. 5/7 refs: add REF_FORCE_CREATE_REFLOG flagDavid Turner, Jul 21, 2015
  10. 6/7 update-ref and tag: add --create-reflog argDavid Turner, Jul 21, 2015
  11. Junio C HamanoJul 21, 2015
  12. Michael HaggertyJul 21, 2015
  13. Michael HaggertyJul 21, 2015
  14. 7/7 git-stash: use update-ref --create-reflog instead of creating filesDavid Turner, Jul 21, 2015
  15. Michael HaggertyJul 21, 2015
  16. David TurnerJul 21, 2015
  17. Junio C HamanoJul 21, 2015
  18. David TurnerJul 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.