git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 6/7] update-ref and tag: add --create-reflog arg

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jul 21, 2015, 20:02 UTC
Message-ID
<55AEA55C.2020501@alum.mit.edu>
In-Reply-To
<xmqqio9dwjh6.fsf@gitster.dls.corp.google.com>
On 07/21/2015 09:42 AM, Junio C Hamano wrote:
Show 16 quoted lines
> David Turner <dturner@twopensource.com> writes:
> 
>> diff --git a/builtin/update-ref.c b/builtin/update-ref.c
>> index 6763cf1..d9646ef 100644
>> --- a/builtin/update-ref.c
>> +++ b/builtin/update-ref.c
>> @@ -14,6 +14,7 @@ static const char * const git_update_ref_usage[] = {
>>  
>>  static char line_termination = '\n';
>>  static int update_flags;
>> +int create_reflog_flag;
> 
> No need to reroll only for this, but I'll s/^int/static &/; while
> queuing.
> 
> I may have more comments later; this was found in the first pass.

In fact, this variable is used as the "flags" argument to ref_transaction_create(), so it should be

    s/^int/static unsigned &/
Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: Junio C HamanoNext: Michael Haggerty
Message 12 of 18 in “refs backend preamble”
  1. 0/7 refs backend preambleDavid Turner, Jul 21, 2015
  2. 1/7 refs.c: add err arguments to reflog functionsDavid Turner, Jul 21, 2015
  3. Michael HaggertyJul 21, 2015
  4. 2/7 refs: Break out check for reflog autocreationDavid Turner, Jul 21, 2015
  5. 3/7 refs: new public ref function: safe_create_reflogDavid Turner, Jul 21, 2015
  6. Michael HaggertyJul 21, 2015
  7. 4/7 git-reflog: add exists commandDavid Turner, Jul 21, 2015
  8. Michael HaggertyJul 21, 2015
  9. 5/7 refs: add REF_FORCE_CREATE_REFLOG flagDavid Turner, Jul 21, 2015
  10. 6/7 update-ref and tag: add --create-reflog argDavid Turner, Jul 21, 2015
  11. Junio C HamanoJul 21, 2015
  12. Michael HaggertyJul 21, 2015
  13. Michael HaggertyJul 21, 2015
  14. 7/7 git-stash: use update-ref --create-reflog instead of creating filesDavid Turner, Jul 21, 2015
  15. Michael HaggertyJul 21, 2015
  16. David TurnerJul 21, 2015
  17. Junio C HamanoJul 21, 2015
  18. David TurnerJul 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.