git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

From
Torsten Bögershausen <tboegi@web.de>
Date
Jul 7, 2015, 09:37 UTC
Message-ID
<559B9DEB.9030409@web.de>
In-Reply-To
<1435666611-18429-8-git-send-email-Matthieu.Moy@imag.fr>
#!/usr/bin/perl
Should we have hard-coded PATH to perl here ?

/usr/bin/perl --version This is perl, v5.10.0 built for darwin-thread-multi-2level (with 2 registered patches, see perl -V for more detail)

> +
> +my $is_passing = Test::More->builder->is_passing;
> +exit($is_passing ? 0 : 1);
>

This seems to give problems: debug=t verbose=t ./t9000-addresses.sh

Initialized empty Git repository in /Users/me/projects/git/git.pu/t/trash directory.t9000-addresses/.git/ # run 0: Perl address parsing function (perl /Users/me/projects/git/git.pu/t/t9000/test.pl) ok 1 - use Git; ok 2 - same output : Jane ok 3 - same output : jdoe@example.com ok 4 - same output : <jdoe@example.com> ok 5 - same output : Jane <jdoe@example.com> ok 6 - same output : Jane Doe <jdoe@example.com> ok 7 - same output : "Jane" <jdoe@example.com> ok 8 - same output : "Doe, Jane" <jdoe@example.com> ok 9 - same output : "Jane@:;\>.,()<Doe" <jdoe@example.com> ok 10 - same output : Jane!\#$%&'*+-/=?^_{|}~Doe' <jdoe@example.com> ok 11 - same output : "<jdoe@example.com>" ok 12 - same output : "Jane jdoe@example.com" ok 13 - same output : Jane Doe <jdoe @ example.com > ok 14 - same output : Jane Doe < jdoe@example.com > ok 15 - same output : Jane @ Doe @ Jane @ Doe ok 16 - same output : "Jane, 'Doe'" <jdoe@example.com> ok 17 - same output : 'Doe, "Jane' <jdoe@example.com> ok 18 - same output : "Jane" "Do"e <jdoe@example.com> ok 19 - same output : "Jane' Doe" <jdoe@example.com> ok 20 - same output : "Jane Doe <jdoe@example.com>" <jdoe@example.com> ok 21 - same output : "Jane\" Doe" <jdoe@example.com> ok 22 - same output : Doe, jane <jdoe@example.com> ok 23 - same output : "Jane Doe <jdoe@example.com> ok 24 - same output : 'Jane 'Doe' <jdoe@example.com> not ok 25 - same output : Jane\ Doe <jdoe@example.com> # TODO known breakage # Failed (TODO) test 'same output : Jane\ Doe <jdoe@example.com>' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = '"Jane \ Doe" <jdoe@example.com>' # $expected->[0] = '"Jane\ Doe" <jdoe@example.com>' not ok 26 - same output : "Doe, Ja"ne <jdoe@example.com> # TODO known breakage # Failed (TODO) test 'same output : "Doe, Ja"ne <jdoe@example.com>' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = '"Doe, Ja" ne <jdoe@example.com>' # $expected->[0] = '"Doe, Ja ne" <jdoe@example.com>' not ok 27 - same output : "Doe, Katarina" Jane <jdoe@example.com> # TODO known breakage # Failed (TODO) test 'same output : "Doe, Katarina" Jane <jdoe@example.com>' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = '"Doe, Katarina" Jane <jdoe@example.com>' # $expected->[0] = '"Doe, Katarina Jane" <jdoe@example.com>' not ok 28 - same output : Jane@:;\.,()<>Doe <jdoe@example.com> # TODO known breakage # Failed (TODO) test 'same output : Jane@:;\.,()<>Doe <jdoe@example.com>' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[1] = '\.' # $expected->[1] = '"\."' not ok 29 - same output : Jane jdoe@example.com # TODO known breakage # Failed (TODO) test 'same output : Jane jdoe@example.com' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = 'Jane' # $expected->[0] = 'Janejdoe@example.com' not ok 30 - same output : <jdoe@example.com> Jane Doe # TODO known breakage # Failed (TODO) test 'same output : <jdoe@example.com> Jane Doe' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = 'Jane Doe <jdoe@example.com>' # $expected->[0] = 'jdoe@example.comJaneDoe' not ok 31 - same output : Jane <jdoe@example.com> Doe # TODO known breakage # Failed (TODO) test 'same output : Jane <jdoe@example.com> Doe' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = 'Jane Doe <jdoe@example.com>' # $expected->[0] = 'Jane <jdoe@example.comDoe>' not ok 32 - same output : "Jane "Kat"a" ri"na" ",Doe" <jdoe@example.com> # TODO known breakage # Failed (TODO) test 'same output : "Jane "Kat"a" ri"na" ",Doe" <jdoe@example.com>' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = '"Jane " Kat "a" ri "na" ",Doe" <jdoe@example.com>' # $expected->[0] = '"Jane Kat a ri na ,Doe" <jdoe@example.com>' not ok 33 - same output : Jane Doe # TODO known breakage # Failed (TODO) test 'same output : Jane Doe' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = 'Jane' # $expected->[0] = 'Jane Doe' not ok 34 - same output : Jane "Doe <jdoe@example.com>" # TODO known breakage # Failed (TODO) test 'same output : Jane "Doe <jdoe@example.com>"' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = 'Jane' # $expected->[0] = '"Jane Doe <jdoe@example.com>"' not ok 35 - same output : \"Jane Doe <jdoe@example.com> # TODO known breakage # Failed (TODO) test 'same output : \"Jane Doe <jdoe@example.com>' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = '\ " Jane Doe <jdoe@example.com>' # $expected->[0] = '"\"Jane Doe" <jdoe@example.com>' not ok 36 - same output : Jane\"\" Doe <jdoe@example.com> # TODO known breakage # Failed (TODO) test 'same output : Jane\"\" Doe <jdoe@example.com>' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = 'Jane \ " \ " Doe <jdoe@example.com>' # $expected->[0] = '"Jane\"\" Doe" <jdoe@example.com>' not ok 37 - same output : 'Jane "Katarina\" \' Doe' <jdoe@example.com> # TODO known breakage # Failed (TODO) test 'same output : 'Jane "Katarina\" \' Doe' <jdoe@example.com>' # at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62. # Structures begin differing at: # $got->[0] = ''Jane " Katarina \ " \ ' Doe' <jdoe@example.com>' # $expected->[0] = '"'Jane Katarina\" \' Doe'" <jdoe@example.com>' 1..37 # test_external test Perl address parsing function failed: perl /Users/me/projects/git/git.pu/t/t9000/test.pl # expecting no stderr from previous command # test_external_without_stderr test no stderr: Perl address parsing function failed: perl /Users/me/projects/git/git.pu/t/t9000/test.pl: # Stderr is: Can't locate object method "is_passing" via package "Test::Builder" at /Users/me/projects/git/git.pu/t/t9000/test.pl line 66. # Looks like your test died just after 37.

Previous: Matthieu MoyNext: Matthieu Moy
Message 14 of 21 in “send-email address management”
  1. 00/10 send-email address managementMatthieu Moy, Jun 30, 2015
  2. 01/10 t9001-send-email: move script creation in a setup testMatthieu Moy, Jun 30, 2015
  3. 02/10 send-email: allow aliases in patch header and command script outputsMatthieu Moy, Jun 30, 2015
  4. 03/10 t9001-send-email: refactor header variable fields replacementMatthieu Moy, Jun 30, 2015
  5. 04/10 send-email: refactor address list processMatthieu Moy, Jun 30, 2015
  6. 05/10 send-email: allow use of aliases in the From field of --compose modeMatthieu Moy, Jun 30, 2015
  7. 06/10 send-email: minor code refactoringMatthieu Moy, Jun 30, 2015
  8. 07/10 send-email: reduce dependencies impact on parse_address_lineMatthieu Moy, Jun 30, 2015
  9. Junio C HamanoJun 30, 2015
  10. Matthieu MoyJun 30, 2015
  11. Junio C HamanoJun 30, 2015
  12. 07/10 send-email: reduce dependencies impact on parse_address_lineRemi Lespinet, Jul 1, 2015
  13. Matthieu MoyJul 1, 2015
  14. Torsten BögershausenJul 7, 2015
  15. Matthieu MoyJul 7, 2015
  16. 07/10 send-email: reduce dependencies impact on parse_address_lineMatthieu Moy, Jul 7, 2015
  17. Torsten BögershausenJul 8, 2015
  18. Matthieu MoyJul 8, 2015
  19. 08/10 send-email: consider quote as delimiter instead of characterMatthieu Moy, Jun 30, 2015
  20. 09/10 send-email: allow multiple emails using --cc, --to and --bccMatthieu Moy, Jun 30, 2015
  21. 10/10 send-email: suppress meaningless whitespaces in from fieldMatthieu Moy, Jun 30, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.