From: Torsten Bögershausen <tboegi@web.de>
Date: Tue, 07 Jul 2015 09:37:47 GMT
Subject: Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line
Message-ID: <559B9DEB.9030409@web.de>
In-Reply-To: <1435666611-18429-8-git-send-email-Matthieu.Moy@imag.fr>

#!/usr/bin/perl

Should we have hard-coded PATH to perl here ?

/usr/bin/perl --version
This is perl, v5.10.0 built for darwin-thread-multi-2level
(with 2 registered patches, see perl -V for more detail)

> +
> +my $is_passing = Test::More->builder->is_passing;
> +exit($is_passing ? 0 : 1);
> 

This seems to give problems:
debug=t verbose=t ./t9000-addresses.sh

Initialized empty Git repository in /Users/me/projects/git/git.pu/t/trash directory.t9000-addresses/.git/
# run 0: Perl address parsing function (perl /Users/me/projects/git/git.pu/t/t9000/test.pl)
ok 1 - use Git;
ok 2 - same output : Jane
ok 3 - same output : jdoe@example.com
ok 4 - same output : <jdoe@example.com>
ok 5 - same output : Jane <jdoe@example.com>
ok 6 - same output : Jane Doe <jdoe@example.com>
ok 7 - same output : "Jane" <jdoe@example.com>
ok 8 - same output : "Doe, Jane" <jdoe@example.com>
ok 9 - same output : "Jane@:;\>.,()<Doe" <jdoe@example.com>
ok 10 - same output : Jane!\#$%&'*+-/=?^_{|}~Doe' <jdoe@example.com>
ok 11 - same output : "<jdoe@example.com>"
ok 12 - same output : "Jane jdoe@example.com"
ok 13 - same output : Jane Doe <jdoe    @   example.com  >
ok 14 - same output : Jane       Doe <  jdoe@example.com  >
ok 15 - same output : Jane @ Doe @ Jane @ Doe
ok 16 - same output : "Jane, 'Doe'" <jdoe@example.com>
ok 17 - same output : 'Doe, "Jane' <jdoe@example.com>
ok 18 - same output : "Jane" "Do"e <jdoe@example.com>
ok 19 - same output : "Jane' Doe" <jdoe@example.com>
ok 20 - same output : "Jane Doe <jdoe@example.com>" <jdoe@example.com>
ok 21 - same output : "Jane\" Doe" <jdoe@example.com>
ok 22 - same output : Doe, jane <jdoe@example.com>
ok 23 - same output : "Jane Doe <jdoe@example.com>
ok 24 - same output : 'Jane 'Doe' <jdoe@example.com>
not ok 25 - same output : Jane\ Doe <jdoe@example.com> # TODO known breakage
#   Failed (TODO) test 'same output : Jane\ Doe <jdoe@example.com>'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = '"Jane \ Doe" <jdoe@example.com>'
#     $expected->[0] = '"Jane\ Doe" <jdoe@example.com>'
not ok 26 - same output : "Doe, Ja"ne <jdoe@example.com> # TODO known breakage
#   Failed (TODO) test 'same output : "Doe, Ja"ne <jdoe@example.com>'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = '"Doe, Ja" ne <jdoe@example.com>'
#     $expected->[0] = '"Doe, Ja ne" <jdoe@example.com>'
not ok 27 - same output : "Doe, Katarina" Jane <jdoe@example.com> # TODO known breakage
#   Failed (TODO) test 'same output : "Doe, Katarina" Jane <jdoe@example.com>'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = '"Doe, Katarina" Jane <jdoe@example.com>'
#     $expected->[0] = '"Doe, Katarina Jane" <jdoe@example.com>'
not ok 28 - same output : Jane@:;\.,()<>Doe <jdoe@example.com> # TODO known breakage
#   Failed (TODO) test 'same output : Jane@:;\.,()<>Doe <jdoe@example.com>'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[1] = '\.'
#     $expected->[1] = '"\."'
not ok 29 - same output : Jane jdoe@example.com # TODO known breakage
#   Failed (TODO) test 'same output : Jane jdoe@example.com'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = 'Jane'
#     $expected->[0] = 'Janejdoe@example.com'
not ok 30 - same output : <jdoe@example.com> Jane Doe # TODO known breakage
#   Failed (TODO) test 'same output : <jdoe@example.com> Jane Doe'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = 'Jane Doe <jdoe@example.com>'
#     $expected->[0] = 'jdoe@example.comJaneDoe'
not ok 31 - same output : Jane <jdoe@example.com> Doe # TODO known breakage
#   Failed (TODO) test 'same output : Jane <jdoe@example.com> Doe'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = 'Jane Doe <jdoe@example.com>'
#     $expected->[0] = 'Jane <jdoe@example.comDoe>'
not ok 32 - same output : "Jane "Kat"a" ri"na" ",Doe" <jdoe@example.com> # TODO known breakage
#   Failed (TODO) test 'same output : "Jane "Kat"a" ri"na" ",Doe" <jdoe@example.com>'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = '"Jane " Kat "a" ri "na" ",Doe" <jdoe@example.com>'
#     $expected->[0] = '"Jane  Kat a ri na ,Doe" <jdoe@example.com>'
not ok 33 - same output : Jane Doe # TODO known breakage
#   Failed (TODO) test 'same output : Jane Doe'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = 'Jane'
#     $expected->[0] = 'Jane Doe'
not ok 34 - same output : Jane "Doe <jdoe@example.com>" # TODO known breakage
#   Failed (TODO) test 'same output : Jane "Doe <jdoe@example.com>"'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = 'Jane'
#     $expected->[0] = '"Jane Doe <jdoe@example.com>"'
not ok 35 - same output : \"Jane Doe <jdoe@example.com> # TODO known breakage
#   Failed (TODO) test 'same output : \"Jane Doe <jdoe@example.com>'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = '\ " Jane Doe <jdoe@example.com>'
#     $expected->[0] = '"\"Jane Doe" <jdoe@example.com>'
not ok 36 - same output : Jane\"\" Doe <jdoe@example.com> # TODO known breakage
#   Failed (TODO) test 'same output : Jane\"\" Doe <jdoe@example.com>'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = 'Jane \ " \ " Doe <jdoe@example.com>'
#     $expected->[0] = '"Jane\"\" Doe" <jdoe@example.com>'
not ok 37 - same output : 'Jane "Katarina\" \' Doe' <jdoe@example.com> # TODO known breakage
#   Failed (TODO) test 'same output : 'Jane "Katarina\" \' Doe' <jdoe@example.com>'
#   at /Users/me/projects/git/git.pu/t/t9000/test.pl line 62.
#     Structures begin differing at:
#          $got->[0] = ''Jane " Katarina \ " \ ' Doe' <jdoe@example.com>'
#     $expected->[0] = '"'Jane  Katarina\" \' Doe'" <jdoe@example.com>'
1..37
# test_external test Perl address parsing function failed: perl /Users/me/projects/git/git.pu/t/t9000/test.pl
# expecting no stderr from previous command
# test_external_without_stderr test no stderr: Perl address parsing function failed: perl /Users/me/projects/git/git.pu/t/t9000/test.pl: 
# Stderr is:
Can't locate object method "is_passing" via package "Test::Builder" at /Users/me/projects/git/git.pu/t/t9000/test.pl line 66.
# Looks like your test died just after 37.