git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] receive-pack: Create a HEAD ref for ref namespace

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Jun 5, 2015, 12:55 UTC
Message-ID
<55719C47.6030600@drmicha.warpmail.net>
In-Reply-To
<ef4dae3e-3ae8-4727-9448-80f801e1dbdf@email.android.com>
Johannes Löthberg venit, vidit, dixit 05.06.2015 13:53:
Show 7 quoted lines
> Ping.
> 
> --
> Sincerely, 
> Johannes Löthberg 
> (Sent from my phone.)
>

It appears your patch proposes to fix a problem. It's a good idea to expose the problem by writing a test so that one can check that the fix actually fixes the problem.

(Also, your patch duplicates the line "struct strbuf namespaced_head_buf = STRBUF_INIT;")

Michael
Previous: Johannes LöthbergNext: Johannes Löthberg
Message 3 of 22 in “receive-pack: Create a HEAD ref for ref namespace”
  1. receive-pack: Create a HEAD ref for ref namespaceJohannes Löthberg, Jun 1, 2015
  2. Johannes LöthbergJun 5, 2015
  3. Michael J GruberJun 5, 2015
  4. Johannes LöthbergJun 5, 2015
  5. Johannes LöthbergJun 5, 2015
  6. Fix cloning from ref namespaceJohannes Löthberg, Jun 5, 2015
  7. 1/2 receive-pack: Create a HEAD ref for ref namespaceJohannes Löthberg, Jun 5, 2015
  8. 2/2 t: Add test for cloning from ref namespaceJohannes Löthberg, Jun 5, 2015
  9. Junio C HamanoJun 5, 2015
  10. Johannes LöthbergJun 5, 2015
  11. Junio C HamanoJun 5, 2015
  12. Johannes LöthbergJun 5, 2015
  13. Johannes LöthbergJun 5, 2015
  14. Junio C HamanoJun 5, 2015
  15. receive-pack: Create a HEAD ref for ref namespaceJohannes Löthberg, Jun 5, 2015
  16. Johannes LöthbergJun 5, 2015
  17. Junio C HamanoJun 5, 2015
  18. Johannes LöthbergJun 5, 2015
  19. receive-pack: Create a HEAD ref for ref namespaceJohannes Löthberg, Jun 5, 2015
  20. Johannes LöthbergJun 10, 2015
  21. Junio C HamanoJun 15, 2015
  22. Johannes LöthbergJun 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.