From: Michael J Gruber Date: Fri, 05 Jun 2015 12:55:35 GMT Subject: Re: [PATCH] receive-pack: Create a HEAD ref for ref namespace Message-ID: <55719C47.6030600@drmicha.warpmail.net> In-Reply-To: Johannes Löthberg venit, vidit, dixit 05.06.2015 13:53: > Ping. > > -- > Sincerely, > Johannes Löthberg > (Sent from my phone.) > It appears your patch proposes to fix a problem. It's a good idea to expose the problem by writing a test so that one can check that the fix actually fixes the problem. (Also, your patch duplicates the line "struct strbuf namespaced_head_buf = STRBUF_INIT;") Michael