git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: honor signoff opt in run_git_commit

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Apr 4, 2024, 19:22 UTC
Message-ID
<54b91c03-5170-493a-8c0c-def2ac1f804a@gmail.com>
In-Reply-To
<xmqqr0fl13gh.fsf@gitster.g>
On 04/04/2024 17:45, Junio C Hamano wrote:
> 	git show -s --format=%B HEAD >actual &&
> 	test_cmp expect actual
> 
> may be a good replacement.
we have test_commit_message to do that these days.
Best Wishes
Phillip
Show 8 quoted lines
> But having said that, and then after having looked at the existing
> tests in the file, I see that it is littered with the same "do not
> run git on the upstream of the pipe" violation.  So let's not worry
> about this one.  The whole t3428 script needs to be cleaned up after
> the dust settles.
> 
> Thanks.
> 
Previous: Junio C HamanoNext: Phillip Wood
Message 4 of 6 in “sequencer: honor signoff opt in run_git_commit”
  1. sequencer: honor signoff opt in run_git_commitDavid Bimmler via GitGitGadget, Apr 4, 2024
  2. Junio C HamanoApr 4, 2024
  3. Junio C HamanoApr 4, 2024
  4. Phillip WoodApr 4, 2024
  5. Phillip WoodApr 4, 2024
  6. David BimmlerApr 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.