From: Phillip Wood <phillip.wood123@gmail.com>
Date: Thu, 04 Apr 2024 19:22:53 GMT
Subject: Re: [PATCH] sequencer: honor signoff opt in run_git_commit
Message-ID: <54b91c03-5170-493a-8c0c-def2ac1f804a@gmail.com>
In-Reply-To: <xmqqr0fl13gh.fsf@gitster.g>

On 04/04/2024 17:45, Junio C Hamano wrote:
> 	git show -s --format=%B HEAD >actual &&
> 	test_cmp expect actual
> 
> may be a good replacement.

we have test_commit_message to do that these days.

Best Wishes

Phillip

> But having said that, and then after having looked at the existing
> tests in the file, I see that it is littered with the same "do not
> run git on the upstream of the pipe" violation.  So let's not worry
> about this one.  The whole t3428 script needs to be cleaned up after
> the dust settles.
> 
> Thanks.
>