Re: [PATCH] git: make was_alias and done_help non-static
Am 02.03.2015 um 13:02 schrieb Alexander Kuleshov:
> 'was_alias' variable does not need to store it's value on each
> iteration in the loop, anyway this variable changes it's value with run_argv.
Show 33 quoted lines
> 'done_help' variable does not need to be static variable too if we'll move it
> out the loop.
>
> So these variables do not need to be static.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
> git.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/git.c b/git.c
> index 1780233..96723b8 100644
> --- a/git.c
> +++ b/git.c
> @@ -619,6 +619,7 @@ int main(int argc, char **av)
> {
> const char **argv = (const char **) av;
> const char *cmd;
> + int done_help, was_alias;
>
> startup_info = &git_startup_info;
>
> @@ -681,8 +682,6 @@ int main(int argc, char **av)
> setup_path();
>
> while (1) {
> - static int done_help = 0;
> - static int was_alias = 0;
> was_alias = run_argv(&argc, &argv);
> if (errno != ENOENT)
> break;
> --
----------------------------------------------------------------
/dev/random says: Recovery program for excessive talkers: On-and-on-Anon.
python -c "print '73746566616e2e6e616577654061746c61732d656c656b74726f6e696b2e636f6d'.decode('hex')"
GPG Key fingerprint = 2DF5 E01B 09C3 7501 BCA9 9666 829B 49C5 9221 27AFStefan Näwe <stefan.naewe@atlas-elektronik.com>