git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git: make was_alias and done_help non-static

From
Alexander Kuleshov <kuleshovmail@gmail.com>
Date
Mar 2, 2015, 12:02 UTC
Message-ID
<1425297757-16431-1-git-send-email-kuleshovmail@gmail.com>

'was_alias' variable does not need to store it's value on each iteration in the loop, anyway this variable changes it's value with run_argv.

'done_help' variable does not need to be static variable too if we'll move it out the loop.

So these variables do not need to be static.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
---
 git.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/git.c b/git.c
index 1780233..96723b8 100644
--- a/git.c
+++ b/git.c
@@ -619,6 +619,7 @@ int main(int argc, char **av)
 {
 	const char **argv = (const char **) av;
 	const char *cmd;
+	int done_help, was_alias;
 
 	startup_info = &git_startup_info;
 
@@ -681,8 +682,6 @@ int main(int argc, char **av)
 	setup_path();
 
 	while (1) {
-		static int done_help = 0;
-		static int was_alias = 0;
 		was_alias = run_argv(&argc, &argv);
 		if (errno != ENOENT)
 			break;
-- 
2.3.1.422.ge618558
Next: Jeff King
Message 1 of 3 in “git: make was_alias and done_help non-static”
  1. git: make was_alias and done_help non-staticAlexander Kuleshov, Mar 2, 2015
  2. Jeff KingMar 2, 2015
  3. Stefan NäweMar 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.