Re: [PATCH] Makefile: Handle broken curl version number in version check

From: Tom G. Christensen <tgc@statsbiblioteket.dk>
Date: Jan 30, 2015, 15:34 UTC
Message-ID: <54CBA497.7040804@statsbiblioteket.dk>
In-Reply-To: <87wq44gw4y.fsf@igel.home>

On 30/01/15 15:50, Andreas Schwab wrote:

Show 15 quoted lines

> "Tom G. Christensen" <tgc@statsbiblioteket.dk> writes:
>
>> diff --git a/Makefile b/Makefile
>> index c44eb3a..69a2ce3 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1035,13 +1035,13 @@ else
>>   	REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)
>>   	PROGRAM_OBJS += http-fetch.o
>>   	PROGRAMS += $(REMOTE_CURL_NAMES)
>> -	curl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null | sort -r | sed -ne 2p)
>> +	curl_check := $(shell (echo 070908; curl-config --vernum | sed -e '/^70[B-C]/ s/^7/07/') 2>/dev/null | sort -r | sed -ne 2p)
>
> How about 's/^.....$/0&/' ?
>

I have no preference so whatever is the most likely to be accepted and does the job is fine with me.

-tgc