Broken makefile check for curl version on el4 [Re: [ANNOUNCE] Git v2.3.0-rc2]

On 28/01/15 00:35, Junio C Hamano wrote:

Building is broken on RHEL4 which is a regression from 2.2.2.

The makefile check for curl >= 7.34.0 fails and enables USE_CURL_FOR_IMAP_SEND even though curl is 7.12.1.

# curl-config --vernum 70C01 # { echo 072200; curl-config --vernum 2>/dev/null ; } | sort -r | sed -ne 2p 072200 #

I checked the curl release tarballs and this problem seems to exist for curl 7.11.0 (0x70B00) through 7.12.2 (0x70C02). In both 7.10.7 (0x070a07) and 7.12.3 (0x070c03) the version is correctly set using 6 hex digits as documented. I tried to verify this using the official curl repo on github but it does not seem to record this discrepancy and shows the correct 6 digit version numbers for the affected releases.

As a workaround I'm piping curl-config --vernum through sed -e '/^70[B-C]/ s/^7/07/'.

-tgc