git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/7] fast-import: minor style fix

From
Torsten Bögershausen <tboegi@web.de>
Date
Jan 23, 2015, 12:22 UTC
Message-ID
<54C23D0C.8020207@web.de>
In-Reply-To
<1422011323-4278-1-git-send-email-kuleshovmail@gmail.com>

On 2015-01-23 12.08, Alexander Kuleshov wrote: .. Asterisk must be next with variable .. But this is a function:

> -static char* make_fast_import_path(const char *path)
> +static char *make_fast_import_path(const char *path)
(Sorry when I need to read this:)
 - Fixing style violations while working on a real change as a
   preparatory clean-up step is good, but otherwise avoid useless code
   churn for the sake of conforming to the style.
   "Once it _is_ in the tree, it's not really worth the patch noise to
   go and fix it up."
   Cf. http://article.gmane.org/gmane.linux.kernel/943020
Previous: Alexander KuleshovNext: Alexander Kuleshov
Message 9 of 11 in “Coding style fixes.”
  1. 0/7 Coding style fixes.Alexander Kuleshov, Jan 23, 2015
  2. 1/7 show-branch: minor style fixAlexander Kuleshov, Jan 23, 2015
  3. 2/7 clone: minor style fixAlexander Kuleshov, Jan 23, 2015
  4. 3/7 test-hashmap: minor style fixAlexander Kuleshov, Jan 23, 2015
  5. 4/7 http-backend: minor style fixAlexander Kuleshov, Jan 23, 2015
  6. 5/7 refs: minor style fixAlexander Kuleshov, Jan 23, 2015
  7. 6/7 quote: minor style fixAlexander Kuleshov, Jan 23, 2015
  8. 7/7 fast-import: minor style fixAlexander Kuleshov, Jan 23, 2015
  9. Torsten BögershausenJan 23, 2015
  10. Alexander KuleshovJan 23, 2015
  11. Stefan BellerJan 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.