From: Torsten Bögershausen <tboegi@web.de>
Date: Fri, 23 Jan 2015 12:22:36 GMT
Subject: Re: [PATCH 7/7] fast-import: minor style fix
Message-ID: <54C23D0C.8020207@web.de>
In-Reply-To: <1422011323-4278-1-git-send-email-kuleshovmail@gmail.com>

On 2015-01-23 12.08, Alexander Kuleshov wrote:
..
Asterisk must be next with variable
..
But this is a function:
> -static char* make_fast_import_path(const char *path)
> +static char *make_fast_import_path(const char *path)

(Sorry when I need to read this:)

 - Fixing style violations while working on a real change as a
   preparatory clean-up step is good, but otherwise avoid useless code
   churn for the sake of conforming to the style.

   "Once it _is_ in the tree, it's not really worth the patch noise to
   go and fix it up."
   Cf. http://article.gmane.org/gmane.linux.kernel/943020