Re: mac test failure -- 2gb clone
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Nov 13, 2014, 05:05 UTC
- Message-ID
- <54643C24.20201@web.de>
- In-Reply-To
- <CAO2U3QjFCBqJ+_E-nyxGnm3GdwB1zJgK6d8SJ4QULQHY1D6bUw@mail.gmail.com>
On 2014-11-12 22.57, Michael Blume wrote:
[t5705-clone-2gb.sh broken on Mac OS]
It is most probably even broken on every platform, since we renovated the URL parser in 2013. (More info can be found here:) git log t/t5601-clone.sh
I missed t5705-clone-2gb.sh, because it has its own enabler variable GIT_TEST_CLONE_2GB instead of using EXPENSIVE as other tests do.
We can say that it as a regression that the URL file://. is no longer supported, and change it like this:
diff --git a/t/t5705-clone-2gb.sh b/t/t5705-clone-2gb.sh index e9783c3..a713118 100755 --- a/t/t5705-clone-2gb.sh +++ b/t/t5705-clone-2gb.sh @@ -46,7 +46,7 @@ test_expect_success CLONE_2GB 'clone - bare' ' test_expect_success CLONE_2GB 'clone - with worktree, file:// protocol' ' - git clone file://. clone-wt + git clone "file://$(pwd)" clone-wt ' Thanks for reporting. Does someone wants to send a patch for t5705-clone-2gb.sh ?