threads / discuss / 37943

mac test failure -- 2gb clone

Subject: mac test failure -- 2gb clone

## tl;dr

3 messages between Nov 12, 2014 and Nov 13, 2014.

replies: 2people: 2as markdown or json

Michael Blume· Nov 12, 2014, 21:57 UTC · lore

This is in pu, haven't checked if it's also in master, this is the first time I've run this test

$ GIT_TEST_CLONE_2GB=t ./t5705-clone-2gb.sh -v Initialized empty Git repository in /Users/michael.blume/workspace/git/t/trash directory.t5705-clone-2gb/.git/ expecting success:

git config pack.compression 0 && git config pack.depth 0 && blobsize=$((100*1024*1024)) && blobcount=$((2*1024*1024*1024/$blobsize+1)) && i=1 && (while test $i -le $blobcount do printf "Generating blob $i/$blobcount\r" >&2 && printf "blob\nmark :$i\ndata $blobsize\n" && #test-genrandom $i $blobsize && printf "%-${blobsize}s" $i && echo "M 100644 :$i $i" >> commit i=$(($i+1)) || echo $? > exit-status done && echo "commit refs/heads/master" && echo "author A U Thor <author@email.com> 123456789 +0000" && echo "committer C O Mitter <committer@email.com> 123456789 +0000" && echo "data 5" && echo ">2gb" && cat commit) | git fast-import --big-file-threshold=2 && test ! -f exit-status

git-fast-import statistics:
---------------------------------------------------------------------
Alloc'd objects:       5000
Total objects:           23 (         0 duplicates                  )
      blobs  :           21 (         0 duplicates          0 deltas
of          0 attempts)
      trees  :            1 (         0 duplicates          0 deltas
of          0 attempts)
      commits:            1 (         0 duplicates          0 deltas
of          0 attempts)
      tags   :            0 (         0 duplicates          0 deltas
of          0 attempts)
Total branches:           1 (         1 loads     )
      marks:           1024 (        21 unique    )
      atoms:             21
Memory total:          2344 KiB
       pools:          2110 KiB
     objects:           234 KiB
---------------------------------------------------------------------
pack_report: getpagesize()            =       4096
pack_report: core.packedGitWindowSize = 1073741824
pack_report: core.packedGitLimit      = 8589934592
pack_report: pack_used_ctr            =          2
pack_report: pack_mmap_calls          =          1
pack_report: pack_open_windows        =          1 /          1
pack_report: pack_mapped              =   54863024 /   54863024
---------------------------------------------------------------------

ok 1 - setup

expecting success:

git clone --bare --no-hardlinks . clone-bare

Cloning into bare repository 'clone-bare'... done. ok 2 - clone - bare

expecting success:

git clone file://. clone-wt

Cloning into 'clone-wt'... fatal: No path specified. See 'man git-pull' for valid url syntax not ok 3 - clone - with worktree, file:// protocol # # # git clone file://. clone-wt # #

# failed 1 among 3 test(s) 1..3

Michael Blume· Nov 12, 2014, 22:09 UTC · re: Michael Blume · lore

Re: mac test failure -- 2gb clone

Confirmed exists on master

On Wed, Nov 12, 2014 at 1:57 PM, Michael Blume <blume.mike@gmail.com> wrote:

Show 89 quoted lines

> This is in pu, haven't checked if it's also in master, this is the
> first time I've run this test
>
> $ GIT_TEST_CLONE_2GB=t ./t5705-clone-2gb.sh -v
> Initialized empty Git repository in
> /Users/michael.blume/workspace/git/t/trash
> directory.t5705-clone-2gb/.git/
> expecting success:
>
> git config pack.compression 0 &&
> git config pack.depth 0 &&
> blobsize=$((100*1024*1024)) &&
> blobcount=$((2*1024*1024*1024/$blobsize+1)) &&
> i=1 &&
> (while test $i -le $blobcount
> do
> printf "Generating blob $i/$blobcount\r" >&2 &&
> printf "blob\nmark :$i\ndata $blobsize\n" &&
> #test-genrandom $i $blobsize &&
> printf "%-${blobsize}s" $i &&
> echo "M 100644 :$i $i" >> commit
> i=$(($i+1)) ||
> echo $? > exit-status
> done &&
> echo "commit refs/heads/master" &&
> echo "author A U Thor <author@email.com> 123456789 +0000" &&
> echo "committer C O Mitter <committer@email.com> 123456789 +0000" &&
> echo "data 5" &&
> echo ">2gb" &&
> cat commit) |
> git fast-import --big-file-threshold=2 &&
> test ! -f exit-status
>
>
> git-fast-import statistics:
> ---------------------------------------------------------------------
> Alloc'd objects:       5000
> Total objects:           23 (         0 duplicates                  )
>       blobs  :           21 (         0 duplicates          0 deltas
> of          0 attempts)
>       trees  :            1 (         0 duplicates          0 deltas
> of          0 attempts)
>       commits:            1 (         0 duplicates          0 deltas
> of          0 attempts)
>       tags   :            0 (         0 duplicates          0 deltas
> of          0 attempts)
> Total branches:           1 (         1 loads     )
>       marks:           1024 (        21 unique    )
>       atoms:             21
> Memory total:          2344 KiB
>        pools:          2110 KiB
>      objects:           234 KiB
> ---------------------------------------------------------------------
> pack_report: getpagesize()            =       4096
> pack_report: core.packedGitWindowSize = 1073741824
> pack_report: core.packedGitLimit      = 8589934592
> pack_report: pack_used_ctr            =          2
> pack_report: pack_mmap_calls          =          1
> pack_report: pack_open_windows        =          1 /          1
> pack_report: pack_mapped              =   54863024 /   54863024
> ---------------------------------------------------------------------
>
> ok 1 - setup
>
> expecting success:
>
> git clone --bare --no-hardlinks . clone-bare
>
>
> Cloning into bare repository 'clone-bare'...
> done.
> ok 2 - clone - bare
>
> expecting success:
>
> git clone file://. clone-wt
>
>
> Cloning into 'clone-wt'...
> fatal: No path specified. See 'man git-pull' for valid url syntax
> not ok 3 - clone - with worktree, file:// protocol
> #
> #
> # git clone file://. clone-wt
> #
> #
>
> # failed 1 among 3 test(s)
> 1..3

Torsten Bögershausen· Nov 13, 2014, 05:05 UTC · re: Michael Blume · lore

Re: mac test failure -- 2gb clone

On 2014-11-12 22.57, Michael Blume wrote:

[t5705-clone-2gb.sh broken on Mac OS]

It is most probably even broken on every platform,
since we renovated the URL parser in 2013.
(More info can be found here:)
 git log t/t5601-clone.sh

I missed t5705-clone-2gb.sh, because it has its own enabler variable GIT_TEST_CLONE_2GB instead of using EXPENSIVE as other tests do.

We can say that it as a regression that the URL file://. is no longer supported, and change it like this:

diff --git a/t/t5705-clone-2gb.sh b/t/t5705-clone-2gb.sh
index e9783c3..a713118 100755
--- a/t/t5705-clone-2gb.sh
+++ b/t/t5705-clone-2gb.sh
@@ -46,7 +46,7 @@ test_expect_success CLONE_2GB 'clone - bare' '
 
 test_expect_success CLONE_2GB 'clone - with worktree, file:// protocol' '
 
-       git clone file://. clone-wt
+       git clone "file://$(pwd)" clone-wt
 
 '

Thanks for reporting.
Does someone wants to send a patch for t5705-clone-2gb.sh ?