Re: [PATCH 1/2] add macro REALLOCARRAY

From: René Scharfe <l.s.r@web.de>
Date: Sep 16, 2014, 18:52 UTC
Message-ID: <541886D5.8060202@web.de>
In-Reply-To: <CAPc5daXuYVXG=b3Mjn=8oE71FqE_PRZ=XHXW_0F5uHawWwy4HQ@mail.gmail.com>

Am 16.09.2014 um 05:04 schrieb Junio C Hamano:

Show 10 quoted lines

> On Sun, Sep 14, 2014 at 9:55 AM, René Scharfe <l.s.r@web.de> wrote:
>> +#define REALLOCARRAY(x, alloc) x = xrealloc((x), (alloc) * sizeof(*(x)))
>
> I have been wondering if "x" could be an expression that has an operator
> that binds weaker than the assignment '='.  That may necessitate the LHS
> of the assignment to be somehow marked as bound the tightest, i.e.
>
> #define REALLOC_ARRAY(x, alloc) (x) = xrealloc((x), (alloc) * sizeof(*(x)))
>
> Or am I being overly silly?

ALLOC_GROW did well without that. I can't think of a good use case for a complex expression on the right-hand side. That said, I think I still have a spare matching pair of parentheses lying around here somewhere, so let's play it safe and use them. :)

The added underscore is a good idea as well.

René