Re: [PATCH 1/2] bisect: remove unnecessary redirection

From: Johannes Sixt <j6t@kdbg.org>
Date: Aug 30, 2014, 20:57 UTC
Message-ID: <54023AA1.40709@kdbg.org>
In-Reply-To: <1409427029-65886-1-git-send-email-davvid@gmail.com>

Am 30.08.2014 21:30, schrieb David Aguilar:

Show 18 quoted lines

> `git rev-parse` is being called with --quiet so there's no need to
> redirect to /dev/null.
> 
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
>  git-bisect.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-bisect.sh b/git-bisect.sh
> index 1e0d602..c1c2321 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -365,7 +365,7 @@ bisect_reset() {
>  	}
>  	case "$#" in
>  	0) branch=$(cat "$GIT_DIR/BISECT_START") ;;
> -	1) git rev-parse --quiet --verify "$1^{commit}" >/dev/null || {
> +	1) git rev-parse --quiet --verify "$1^{commit}" || {

This is wrong. The redirection quells stdout, but --quiet is about stderr.

>  			invalid="$1"
>  			die "$(eval_gettext "'\$invalid' is not a valid commit")"
>  		}
>

-- Hannes