git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] bisect: remove unnecessary redirection

From
David Aguilar <davvid@gmail.com>
Date
Aug 30, 2014, 19:30 UTC
Message-ID
<1409427029-65886-1-git-send-email-davvid@gmail.com>

`git rev-parse` is being called with --quiet so there's no need to redirect to /dev/null.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
 git-bisect.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 1e0d602..c1c2321 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -365,7 +365,7 @@ bisect_reset() {
 	}
 	case "$#" in
 	0) branch=$(cat "$GIT_DIR/BISECT_START") ;;
-	1) git rev-parse --quiet --verify "$1^{commit}" >/dev/null || {
+	1) git rev-parse --quiet --verify "$1^{commit}" || {
 			invalid="$1"
 			die "$(eval_gettext "'\$invalid' is not a valid commit")"
 		}
-- 
2.1.0.29.g9b751c4
Next: David Aguilar
Message 1 of 5 in “bisect: remove unnecessary redirection”
  1. 1/2 bisect: remove unnecessary redirectionDavid Aguilar, Aug 30, 2014
  2. 2/2 stash: prefer --quiet over shell redirectionDavid Aguilar, Aug 30, 2014
  3. Johannes SixtAug 30, 2014
  4. David AguilarAug 31, 2014
  5. Johannes SixtAug 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.