Re: [PATCH] bisect: save heap memory. allocate only the required amount
- From
Stefan Beller <stefanbeller@gmail.com>
- Date
- Aug 24, 2014, 15:10 UTC
- Message-ID
- <53FA0054.5060808@gmail.com>
- In-Reply-To
- <1408889844-5407-1-git-send-email-arjun024@gmail.com>
On 24.08.2014 16:17, Arjun Sreedharan wrote:
Show 18 quoted lines
> Find and allocate the required amount instead of
> allocating extra 100 bytes
>
> Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
> ---
> bisect.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/bisect.c b/bisect.c
> index d6e851d..c96aab0 100644
> --- a/bisect.c
> +++ b/bisect.c
> @@ -215,10 +215,13 @@ static struct commit_list *best_bisection_sorted(struct commit_list *list, int n
> }
> qsort(array, cnt, sizeof(*array), compare_commit_dist);
> for (p = list, i = 0; i < cnt; i++) {
> - struct name_decoration *r = xmalloc(sizeof(*r) + 100);
> + char name[100];Would it make sense to convert the 'name' into a git strbuf? Please have a look at Documentation/technical/api-strbuf.txt
Show 11 quoted lines
> + sprintf(name, "dist=%d", array[i].distance); > + int name_len = strlen(name); > + struct name_decoration *r = xmalloc(sizeof(*r) + name_len); > struct object *obj = &(array[i].commit->object); > > - sprintf(r->name, "dist=%d", array[i].distance); > + memcpy(r->name, name, name_len + 1); > r->next = add_decoration(&name_decoration, obj, r); > p->item = array[i].commit; > p = p->next; >