Re: [PATCH 1/3] log-tree: make add_name_decoration a public function

From: Jeff King <peff@peff.net>
Date: Aug 26, 2014, 12:17 UTC
Message-ID: <20140826121710.GB29180@peff.net>
In-Reply-To: <53FC7408.1030708@ramsay1.demon.co.uk>

On Tue, Aug 26, 2014 at 12:48:24PM +0100, Ramsay Jones wrote:

> > We can fix this by making name_decoration's adding function
> > public. If all callers use it, then any changes to structi
> 
> s/structi/struct/

I blame vi finger-cruft.

Show 9 quoted lines

> > initialization only need to happen in one place (and because
> > the members come in as parameters, the compiler can notice a
> > caller who does not supply enough information).
> > 
> > As a bonus, this also means that the decoration hashes
> > created by the bisect code will use less memory (previously
> > we over-allocated space for the distance integer, but not we
> 
> s/not/now/

Er, I blame vi again. Yeah, that's my story and I'm sticking to it.

Thanks for proofreading. :)

-Peff