git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] http: fix charset detection of extract_content_type()

From
nori <semtlenori@gmail.com>
Date
Jun 14, 2014, 18:49 UTC
Message-ID
<539caff7.e7bc420a.76b9.fffff853@mx.google.com>

extract_content_type() could not extract a charset parameter if the parameter is not the first one and there is a whitespace and a following semicolon just before the parameter. For example:

    text/plain; format=fixed ;charset=utf-8
Signed-off-by: Yi EungJun <eungjun.yi@navercorp.com>
---
 http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/http.c b/http.c
index 2b4f6a3..05e8b91 100644
--- a/http.c
+++ b/http.c
@@ -971,7 +971,7 @@ static void extract_content_type(struct strbuf *raw, struct strbuf *type,
 
 	strbuf_reset(charset);
 	while (*p) {
-		while (isspace(*p))
+		while (isspace(*p) || *p == ';')
 			p++;
 		if (!extract_param(p, "charset", charset))
 			return;
-- 
2.0.0.422.gb6302de
Next: Yi EungJun
Message 1 of 5 in “http: fix charset detection of extract_content_type()”
  1. http: fix charset detection of extract_content_type()nori, Jun 14, 2014
  2. Yi EungJunJun 15, 2014
  3. Junio C HamanoJun 16, 2014
  4. Jeff KingJun 16, 2014
  5. Jeff KingJun 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.