Re: [PATCH] http: fix charset detection of extract_content_type()
- From
Jeff King <peff@peff.net>
- Date
- Jun 16, 2014, 19:20 UTC
- Message-ID
- <20140616192005.GA19322@sigill.intra.peff.net>
- In-Reply-To
- <xmqqha3kr9m4.fsf@gitster.dls.corp.google.com>
On Mon, Jun 16, 2014 at 11:29:39AM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> nori <semtlenori@gmail.com> writes: > > > extract_content_type() could not extract a charset parameter if the > > parameter is not the first one and there is a whitespace and a following > > semicolon just before the parameter. For example: > > > > text/plain; format=fixed ;charset=utf-8 > > > > Signed-off-by: Yi EungJun <eungjun.yi@navercorp.com> > > --- > > Peff, doesn't this look somehow familiar? Perhaps with e3131626 > (http: optionally extract charset parameter from content-type, > 2014-05-22), this patch is unnecessary?
No, I think this is built on top of e3131626 to catcha case I mised. It looks OK at first glance, but I'd really like to add better test coverage for this parsing.
-Peff