Re: [PATCH 2/3] gpg-interface: provide access to the payload

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jun 13, 2014, 09:44 UTC
Message-ID: <539AC7FC.8040707@drmicha.warpmail.net>
In-Reply-To: <20140613075550.GI7908@sigill.intra.peff.net>

Jeff King venit, vidit, dixit 13.06.2014 09:55:

Show 17 quoted lines

> On Fri, Jun 06, 2014 at 04:15:27PM +0200, Michael J Gruber wrote:
> 
>> diff --git a/builtin/merge.c b/builtin/merge.c
>> [...]
>> +			free(signature_check.payload);
>>  			free(signature_check.gpg_output);
>>  			free(signature_check.gpg_status);
>>  			free(signature_check.signer);
>> [...]
>> diff --git a/pretty.c b/pretty.c
>> [...]
>> +	free(context.signature_check.payload);
>>  	free(context.signature_check.gpg_output);
>>  	free(context.signature_check.gpg_status);
>>  	free(context.signature_check.signer);
> 
> Perhaps this is a sign that we need a "signature_check_clear()" helper?

... or simply switch to language which has (or can overload) free for an object :)

Do we have prior art for such helpers so that the new one would be analogous?

Michael