Re: [PATCH] git-submodule.sh: avoid "test <cond> -a/-o <cond>"

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jun 10, 2014, 15:20 UTC
Message-ID: <53972229.5040104@viscovery.net>
In-Reply-To: <xmqq7g4obypt.fsf@gitster.dls.corp.google.com>

Am 6/10/2014 16:55, schrieb Junio C Hamano:

Show 13 quoted lines

> Elia Pinto <gitter.spiros@gmail.com> writes:
> 
>> @@ -832,7 +832,7 @@ Maybe you want to use 'update --init'?")"
>>  			continue
>>  		fi
>>  
>> -		if ! test -d "$sm_path"/.git -o -f "$sm_path"/.git
>> +		if ! test -d "$sm_path"/.git || test -f "$sm_path"/.git
> 
> Which part of test conditions does that "!" apply in the original,
> and in the updated? 
> 
> I think the new test after || also needs negation, no?

Not just that; the || must be turned into && as well.

I noticed a similar construct later in the patch in a review of an earlier iteration, but missed this one.

-- Hannes