Re: [PATCH] git-submodule.sh: avoid "test <cond> -a/-o <cond>"

From: Torsten Bögershausen <tboegi@web.de>
Date: Jun 10, 2014, 14:52 UTC
Message-ID: <53971BBE.8030108@web.de>
In-Reply-To: <1402403313-22468-1-git-send-email-gitter.spiros@gmail.com>

On 2014-06-10 14.28, Elia Pinto wrote: []

Show 9 quoted lines

>  		# before the first commit: compare with an empty tree
>  		head=$(git hash-object -w -t tree --stdin </dev/null)
> @@ -1056,13 +1056,17 @@ cmd_summary() {
>  		while read mod_src mod_dst sha1_src sha1_dst status sm_path
>  		do
>  			# Always show modules deleted or type-changed (blob<->module)
> -			test $status = D -o $status = T && echo "$sm_path" && continue
> +			case "$status" in
> +			([DT])

Does this look strange? ^ Should it be case "$status" in D|T)